Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.ts #392

Closed
wants to merge 1 commit into from
Closed

Update index.ts #392

wants to merge 1 commit into from

Conversation

alexeagle
Copy link
Member


Changes are visible to end-users: yes/no

  • Searched for relevant documentation and updated as needed: yes/no
  • Breaking change (forces users to change their own code or config): yes/no
  • Suggested release notes appear below: yes/no

Test plan

  • Covered by existing test cases
  • New test cases added
  • Manual testing; please provide instructions so we can reproduce:

Copy link
Contributor

aspect-workflows bot commented Jan 13, 2025

Test

All tests were cache hits

27 tests (100.0%) were fully cached saving 15s.


Format

Formatting check has failed

💡 Some formatting failures can be fixed automatically by running the command below, while others may require manual fixes

bazel run //:format -- logger/frontend/index.ts

ℹ️ A patch file containing the changes has been archived as an artifact of this build


Lint

.

1 issues require fixes
1 issues can be fixed automatically

💡 Reproduce linting failures with:

bazel lint //logger/frontend:compile_typings

💡 Auto-fix linting errors with:

bazel lint //logger/frontend:compile_typings --fix

Lint

@@ -14,7 +14,8 @@
}

private checkStatus(response: Response): Promise<Response> {
console.log('in check status');
const msg: string = 'in check status';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint provided a suggestion

Suggested change
const msg: string = 'in check status';
const msg = 'in check status';

@alexeagle alexeagle closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant