Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add a go_test so we can measure some coverage #405

Merged
merged 2 commits into from
Jan 30, 2025
Merged

chore: add a go_test so we can measure some coverage #405

merged 2 commits into from
Jan 30, 2025

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented Jan 30, 2025 •
edited
Loading

locally running bazel coverage on this target

% cat /private/var/tmp/_bazel_alexeagle/2442372bc9d5c407aa13d3b43880afe0/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/oci_go_image/app_test/coverage.dat
SF:oci_go_image/main.go
FNF:0
FNH:0
DA:9,1

@alexeagle alexeagle requested a review from thesayyn January 30, 2025 00:44
@aspect-workflows Aspect Workflows
Copy link
Contributor

aspect-workflows bot commented Jan 30, 2025 •
edited
Loading

Test

1 test target passed

Targets 
//oci_go_image:app_test [k8-fastbuild] 332ms

Total test execution time was 332ms. 27 tests (96.4%) were fully cached saving 29s.

Format      Lint [.]

@alexeagle alexeagle enabled auto-merge (squash) January 30, 2025 01:28
@alexeagle alexeagle requested a review from kormide January 30, 2025 15:21
kormide
kormide requested changes Jan 30, 2025
View reviewed changes
oci_go_image/main_test.go Outdated
"testing"
)

func TestGenerateNumber(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestCompare?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha yes, some copy pasta going on here :)

@alexeagle alexeagle merged commit 3f7ad86 into main Jan 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kormide kormide kormide approved these changes

@thesayyn thesayyn Awaiting requested review from thesayyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @kormide