perf: only emit aspect_rules_js_metadata when required (#1420)

aspect-build · Jan 6, 2024 · 42b751a · 42b751a
1 parent 6e2437a
commit 42b751a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/js/private/test/image/structure/digests.sum b/js/private/test/image/structure/digests.sum
@@ -1,2 +1,2 @@
 9546c440ffbbe36177f305a1aec4bf89fa08eea5926fe828c8e9edd8e08a16a7
-d26b897f8c3e3c3464f5acfd50ad56793f82f1f362e2bc2a78bc6a77204561cc
+ea187b7d895f6fecc13eb08ff07bc9a1765a39cd082d4cfbb65739d0e66dcf95
diff --git a/js/private/test/image/structure/node_modules_structure.mf b/js/private/test/image/structure/node_modules_structure.mf
@@ -23,7 +23,6 @@ app/js/private/test/image/structure/bin.runfiles/aspect_rules_js/node_modules/.a
 app/js/private/test/image/structure/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/CHANGELOG.md
 app/js/private/test/image/structure/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/LICENSE
 app/js/private/test/image/structure/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/README.md
-app/js/private/test/image/structure/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/aspect_rules_js_metadata.json
 app/js/private/test/image/structure/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/bin
 app/js/private/test/image/structure/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/bin/acorn
 app/js/private/test/image/structure/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/dist

diff --git a/npm/private/npm_import.bzl b/npm/private/npm_import.bzl
@@ -598,8 +598,10 @@ bin = bin_factory("node_modules")
     if rctx.attr.custom_postinstall:
         rules_js_metadata["scripts"] = {}
         rules_js_metadata["scripts"]["custom_postinstall"] = rctx.attr.custom_postinstall
-    rules_js_json_path = paths.join(_EXTRACT_TO_DIRNAME, "aspect_rules_js_metadata.json")
-    rctx.file(rules_js_json_path, json.encode_indent(rules_js_metadata, indent = "  "))
+
+    if rules_js_metadata:
+        rules_js_json_path = paths.join(_EXTRACT_TO_DIRNAME, "aspect_rules_js_metadata.json")
+        rctx.file(rules_js_json_path, json.encode_indent(rules_js_metadata, indent = "  "))
 
     for filename, contents in rctx_files.items():
         rctx.file(filename, "\n".join(contents))