Skip to content

Commit

Permalink
chore: make release functional
Browse files Browse the repository at this point in the history
  • Loading branch information
alexeagle committed Nov 2, 2021
1 parent f95b289 commit c7d2864
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 8 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,14 @@ jobs:
- name: Checkout
uses: actions/checkout@v2
- uses: bazelbuild/setup-bazelisk@v1
- name: check git state is clean
run: git status --porcelain
- name: bazel test //...
env:
# Bazelisk will download bazel to here
XDG_CACHE_HOME: ~/.cache/bazel-repo
run:
bazel --bazelrc=.github/workflows/ci.bazelrc --bazelrc=.bazelrc test
--config=release //...
bazel --bazelrc=.github/workflows/ci.bazelrc --bazelrc=.bazelrc test //...
- name: Release
uses: softprops/action-gh-release@v1
with:
prerelease: true
files: |
bazel-out/*/bin/path/to/some/output
files: bazel-out/*/bin/*.tar.gz
8 changes: 8 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,11 @@ echo "query $OVERRIDE" >> ~/.bazelrc
```

This means that any usage of `@rules_js` on your system will point to this folder.

## Releasing

1. Update the constant in `version.bzl`
1. `git tag v$(grep VERSION version.bzl | cut -d'"' -f2)`
1. git push --tags
1. Watch the automation run on GitHub actions
1. Update the release page with auto-generated release notes
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ http_archive(
sha256 = "",
)

load("@aspect_rules_js//js:repositories.bzl", "js_rules_dependencies")
load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

# This fetches the aspect_rules_js dependencies, which are:
# - bazel_skylib
Expand Down
2 changes: 1 addition & 1 deletion js/private/nodejs_binary.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def _bash_launcher(ctx, linkable):
{rlocation_function}
set -o pipefail -o errexit -o nounset
{node_path}
NODE_DEBUG=module $(rlocation {node}) \\
$(rlocation {node}) \\
$(rlocation {entry_point}) \\
{args} $@
""".format(
Expand Down

0 comments on commit c7d2864

Please sign in to comment.