WIP Avoid double-parsing lockfile in bzlmod #1808
Draft
+118
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this takes a slightly different approach from jbedard@2ba1311, so we can pass back the state and reuse it. I'm stuck on the following error, I can't figure out how this repo is created:
ERROR: module extension "npm" from "//npm:extensions.bzl" does not generate repository "npm", yet it is imported as "npm"Also, this is skipping some of the coercion logic in
npm_translate_lockmacro because I was a bit lazy; I think factoring that into helpers should work or maybe duplicating it isn't the end of the world.Does this seem sane?