Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: join --descriptor_set_in with host path separator #671

Merged
merged 3 commits into from
Nov 12, 2024

Commits on Nov 4, 2024

  1. fix: join --descriptor_set_in with host path separator

    Fixes aspect-build#670.
    
    As described in aspect-build#670, protoc splits the arguments to `--proto_path` and `--descriptor_set_in` using an OS-specific path-separator. On posix, this is `:`, but on Windows this is `;`. The protobuf library takes the approach for its bazel rules to join on `ctx.configuration.host_path_separator`, so I've taken the same approach here as well.
    willjschmitt committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c71f266 View commit details
    Browse the repository at this point in the history
  2. fixup: add simple unit test for ts_proto_library

    This only simply tests a basic message that depends on a message in another package, but for the scope of the current issue is appropriate. It's probably worth testing grpc functionality, too, but the examples package provides coverage.
    willjschmitt committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    f00e046 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Configuration menu
    Copy the full SHA
    ad33d2f View commit details
    Browse the repository at this point in the history