-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: import toolchains to use for copy actions #135
feat: import toolchains to use for copy actions #135
Conversation
Register the "coreutils" toolchains using definitions imported from the "bazel_lib" Bazel repository in order to allow use of this module with "bazel_lib" version 2 and later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for the update!
The CI failure with Bazel 5.3.2 looks familiar:
We'll have to green this up before landing. I'll look deeper later tonight or tomorrow when I have some time. |
Just by way of the error message, it sounds like it may be related to bazelbuild/bazel#15175, though in this case the failure was with Ubuntu Linux, not macOS. Reading further, there is bazel-contrib/bazel-lib#392. You noted in bazel-contrib/bazel-lib#392 (comment) that there's a workaround that my patch here undid, by way of removing the "override_local_config_platform" attribute value supplied to |
Commit 7848eb2 adds that "override_local_config_platform" attribute back into the call to |
Can we please allow this most recent commit to pass through the CI workflow? I'd like to see whether it resolves the previous problem. |
Well, clearly that didn't work. That attribute is no longer known to |
7848eb2
to
452abb1
Compare
I removed that previous attempt to use the "override_local_config_platform" attribute (per #135 (comment)). Do we need to continue supporting Bazel version 5.3.2 in our CI workflow? |
I'm working on a PR to bump all the bazel deps and test only on Bazel 7 & 6. That will drop Bazel 5 from the CI matrix. |
Register the "coreutils" toolchains using definitions imported from the bazel_lib Bazel repository in order to allow use of this module with bazel_lib version 2 and later.
Type of change
New feature or functionality (change which adds functionality)
Test plan
Covered by existing test cases
See aspect-build/rules_esbuild#165 for precedent.
Fixes #134.