Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rust code generation #3

Merged
merged 9 commits into from
Oct 10, 2023

Conversation

harlem88
Copy link
Collaborator

@harlem88 harlem88 commented Sep 15, 2023

The rust code generated by proto files wad added under version control, on each pull_request a CI action will check if there is a difference between the code generated by CI and the rust code committed in the Pull Request.

@harlem88 harlem88 force-pushed the rust-support branch 17 times, most recently from 61eb355 to b60e924 Compare September 18, 2023 14:20
@harlem88 harlem88 force-pushed the rust-support branch 13 times, most recently from 6ce23ea to c447304 Compare September 29, 2023 13:45
@harlem88 harlem88 force-pushed the rust-support branch 4 times, most recently from b52a8ed to 6c2f269 Compare October 9, 2023 09:17
Signed-off-by: Antonio Gisondi <[email protected]>
@harlem88 harlem88 force-pushed the rust-support branch 7 times, most recently from ebafc61 to 36ca721 Compare October 9, 2023 12:58
@harlem88 harlem88 marked this pull request as ready for review October 9, 2023 13:05
.github/workflows/check-code-generation.yaml Outdated Show resolved Hide resolved
.github/workflows/check-code-generation.yaml Outdated Show resolved Hide resolved
.github/workflows/code-generation.yaml Outdated Show resolved Hide resolved
.github/workflows/rust-publish.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@rgallor rgallor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@harlem88 harlem88 force-pushed the rust-support branch 2 times, most recently from d4cd3c9 to 789f822 Compare October 9, 2023 13:26
Copy link
Collaborator

@sorru94 sorru94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming some of the checkers could make the CI clearer. The three checkers below are very similar.

  • check-code-generation.yaml
  • rust-check-build.yaml
  • rust-code-check.yaml

check-code-generation.yaml will also eventually contain the check for Python right? If so then the generic name looks good.
I would rename rust-check-build.yaml to something more explicative. The check is on the build tools, not the building process. How about something like rust-check-builder.yaml, rust-check-tools.yaml.
For rust-code-check.yaml the name could be similar to check-code-generation.yaml since the purpose is the same but only for Rust files. How about something like rust-check-code-generation.yaml?

My suggestion is also for the workflow name contained in the .yaml files. Those names could be similar to the file name in order to make the file easy to find knowing only the name and vice-versa.

@harlem88 harlem88 force-pushed the rust-support branch 2 times, most recently from b48337d to 0a212d5 Compare October 9, 2023 15:20
Signed-off-by: Antonio Gisondi <[email protected]>
@harlem88 harlem88 requested a review from sorru94 October 9, 2023 15:27
@sorru94 sorru94 merged commit 131aebd into astarte-platform:master Oct 10, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants