-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enrich message hub api #56
Conversation
e55155b
to
3646684
Compare
e98e53c
to
da8b9d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes on the rust side, otherwise looks good.
Maybe we should add a one line doc on the pub functions, but not really necessary.
Signed-off-by: Riccardo Gallo <[email protected]>
Signed-off-by: Riccardo Gallo <[email protected]>
Signed-off-by: Riccardo Gallo <[email protected]>
Signed-off-by: Riccardo Gallo <[email protected]>
0de7994
to
fe94c12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a few lines to the changelog on these new proto definitions.
Implement Error trait to handle a MessageHubError with source and back-trace when used. The Display implementation will just print the description of the Error. Signed-off-by: Riccardo Gallo <[email protected]>
Signed-off-by: Riccardo Gallo <[email protected]>
8f8f6ee
to
473eac5
Compare
Signed-off-by: Riccardo Gallo <[email protected]>
Closes #7