Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich message hub api #56

Merged
merged 7 commits into from
Aug 23, 2024
Merged

Conversation

rgallor
Copy link
Collaborator

@rgallor rgallor commented Jul 10, 2024

Closes #7

@rgallor rgallor force-pushed the change-msg-api branch 2 times, most recently from e55155b to 3646684 Compare July 10, 2024 09:22
@rgallor rgallor force-pushed the change-msg-api branch 2 times, most recently from e98e53c to da8b9d0 Compare July 25, 2024 13:34
Copy link
Contributor

@joshuachp joshuachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes on the rust side, otherwise looks good.

Maybe we should add a one line doc on the pub functions, but not really necessary.

rust/astarte-message-hub-proto/src/proto_message_hub.rs Outdated Show resolved Hide resolved
rust/astarte-message-hub-proto/src/proto_message_hub.rs Outdated Show resolved Hide resolved
rust/astarte-message-hub-proto/src/proto_message_hub.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@harlem88 harlem88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a few lines to the changelog on these new proto definitions.

Implement Error trait to handle a MessageHubError with source and back-trace
when used. The Display implementation will just print the description of
the Error.

Signed-off-by: Riccardo Gallo <[email protected]>
@harlem88 harlem88 requested a review from sorru94 August 22, 2024 10:18
@harlem88 harlem88 merged commit 908e34d into astarte-platform:master Aug 23, 2024
13 checks passed
@rgallor rgallor deleted the change-msg-api branch August 23, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a layer on AstarteMessage to enrich the API
4 participants