Separate type check diagnostics builder #13978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
force-pushed
the
dhruv/diagnostics-builder
branch
2 times, most recently
from
5cbd74e
to
257ce5a
Compare
|
dhruvmanila
force-pushed
the
dhruv/diagnostics-builder
branch
from
257ce5a
to
bd0d782
Compare
dhruvmanila
commented
Oct 30, 2024
dhruvmanila
requested review from
carljm,
MichaReiser and
AlexWaygood
as code owners
MichaReiser
reviewed
Oct 30, 2024
dhruvmanila
force-pushed
the
dhruv/diagnostics-builder
branch
from
8d3a2ff
to
b50d38c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates a new
TypeCheckDiagnosticsBuilderfor theTypeCheckDiagnosticsstruct. The main motivation behind this is to separate the helpers required to build the diagnostics from the type inference builder itself. This allows us to use such helpers outside of the inference builder like for example in the unpacking logic in #13979.Test Plan
cargo insta test