Fix formatting of single with-item with trailing comment #14005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
added
bug
MichaReiser
force-pushed
the
micha/fix-single-with-trailing-comment
branch
from
f8d5a2f
to
4cf8b9e
Compare
MichaReiser
force-pushed
the
micha/fix-single-with-trailing-comment
branch
from
4cf8b9e
to
d132638
Compare
|
|
How quick! Thanks! I see what you mean about this not being fun stuff to fix 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14001
The root cause of the incorrect formatting is that
is_expression_parenthesizedreturns true forwith (expression)because it can'tdetermine that the parentheses belong to the with statement and not the expression.
The fix is to disregard whether the expression is parenthesized when the with statement is parenthesized and it's a single item.
Preview
We need to gate this behind preview because the formatter now removes the unnecessary parentheses
Test Plan
Added test