Fix panic when filling up types vector during unpacking #14006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
requested review from
carljm,
MichaReiser and
AlexWaygood
as code owners
dhruvmanila
commented
Oct 30, 2024
dhruvmanila
force-pushed
the
dhruv/fix-unpack-panic
branch
from
e44f117
to
9e5b1f9
Compare
dhruvmanila
force-pushed
the
dhruv/fix-unpack-panic
branch
from
9e5b1f9
to
b36897d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a panic which can occur in an unpack assignment when:
The reason being that the
insertpanics because the index is greater than the length.This is an error case and so practically it should occur very rarely. The solution is to resize the types vector to match the number of expressions and then insert the starred expression type.
Test Plan
Add a new test case.