-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flake8-bandit
] Report all references to suspicious functions (S3
)
#15541
Open
InSyncWithFoo
wants to merge
5
commits into
astral-sh:main
Choose a base branch
from
InSyncWithFoo:S307
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
S321 | 6 | 6 | 0 | 0 | 0 |
S307 | 1 | 1 | 0 | 0 | 0 |
S301 | 1 | 1 | 0 | 0 | 0 |
InSyncWithFoo
changed the title
[
[Jan 17, 2025
flake8-bandit
] Report all references (S3
)flake8-bandit
] Report all references to suspicious functions (S3
)
The ecosystem changes are mostly as expected, except for this: class FTPSHook(FTPHook):
def get_conn(self) -> ftplib.FTP:
# ^^^^^^^^^^ Should references in type hints be reported? |
dhruvmanila
reviewed
Jan 17, 2025
crates/ruff_linter/src/rules/flake8_bandit/rules/suspicious_function_call.rs
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_bandit/rules/suspicious_function_call.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_bandit/rules/suspicious_function_call.rs
Show resolved
Hide resolved
I think we should ignore them which, I think, is what you've done as well in this PR. |
dhruvmanila
added
rule
Implementing or modifying a lint rule
preview
Related to preview mode features
labels
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #15522.
Test Plan
cargo nextest run
andcargo insta test
.