Python harmonic #44
Merged
Python harmonic #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
reviewed
Jan 22, 2022
|
|
||
| @fixture | ||
| def rng(request): | ||
| return np.random.default_rng(getattr(request.config.option, "randomly_seed", None)) |
There was a problem hiding this comment.
Yay for new numpy.random 😄
paddyroddy
reviewed
Jan 22, 2022
Comment on lines
+28
to
+48
| @mark.parametrize( | ||
| "px2wav,wav2px", | ||
| [ | ||
| ( | ||
| partial(analysis_lm2lmn, spin=0, upsample=1, N=1), | ||
| partial(analysis_adjoint_lmn2lm, spin=0, upsample=1, N=1), | ||
| ), | ||
| ( | ||
| partial(analysis_lm2lmn, spin=2, upsample=1, N=1), | ||
| partial(analysis_adjoint_lmn2lm, spin=2, upsample=1, N=1), | ||
| ), | ||
| ( | ||
| partial(synthesis_adjoint_lm2lmn, spin=0, upsample=1, N=1), | ||
| partial(synthesis_lmn2lm, spin=0, upsample=1, N=1), | ||
| ), | ||
| ( | ||
| partial(synthesis_adjoint_lm2lmn, spin=2, upsample=1, N=1), | ||
| partial(synthesis_lmn2lm, spin=2, upsample=1, N=1), | ||
| ), | ||
| ], | ||
| ) |
There was a problem hiding this comment.
noice, btw if you're not aware the library hypothesis is great for getting a test to run multiple circumstances
paddyroddy
reviewed
Jan 22, 2022
| ], | ||
| ) | ||
| def test_axisym_adjoint( | ||
| px2wav, wav2px, rng: np.random.Generator, L=10, B=2, J_min=2 |
There was a problem hiding this comment.
nit: would be great if typing was used everywhere 😉
paddyroddy
reviewed
Jan 22, 2022
paddyroddy
reviewed
Jan 22, 2022
paddyroddy
requested changes
Jan 22, 2022
jasonmcewen
requested review from
mdavezac
and removed request for
jasonmcewen
mdavezac
approved these changes
Jan 26, 2022
|
who has the authority to merge and deploy this? @mdavezac @jasonmcewen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carrying on from #22. Python wrappers for the wavelet transforms and adjoints in harmonic space. So far only had wrappers for the pixel space transforms. This goes some way towards #20