Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ucd schema validation #60

Merged
merged 5 commits into from
Jun 13, 2024
Merged

add ucd schema validation #60

merged 5 commits into from
Jun 13, 2024

Conversation

arjunsavel
Copy link
Collaborator

Addresses #42. Done in schema as opposed to data integrity test.

@arjunsavel arjunsavel requested a review from dr-rodriguez June 4, 2024 19:58
@arjunsavel
Copy link
Collaborator Author

@dr-rodriguez bump whenever you get a chance!

@dr-rodriguez
Copy link
Contributor

dr-rodriguez commented Jun 11, 2024

Can you update the test_schema.py file to include a test that shows UCD pass and one that shows the UCD fails?

tests/test_schema.py Outdated Show resolved Hide resolved
@arjunsavel arjunsavel requested a review from dr-rodriguez June 12, 2024 19:20
@arjunsavel arjunsavel merged commit d12af68 into main Jun 13, 2024
1 check passed
@arjunsavel arjunsavel deleted the test_ucd branch June 13, 2024 14:26
@arjunsavel arjunsavel mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants