Finish tests

astronomer · Jan 16, 2025 · 8bf5191 · 8bf5191
1 parent 7c58bad
commit 8bf5191
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/templates/git-sync-relay/git-sync-relay-deployment.yaml b/templates/git-sync-relay/git-sync-relay-deployment.yaml
@@ -76,7 +76,6 @@ spec:
               readOnly: true
               subPath: known_hosts
             {{- end }}
-          # TODO: Use the pvc when this is set to volume mode
             {{- end }}
             - name: git-repo-contents
               mountPath: /git

diff --git a/tests/chart/test_git_sync_relay_deployment.py b/tests/chart/test_git_sync_relay_deployment.py
@@ -41,7 +41,10 @@ def test_gsr_deployment_gsr_mode_daemon(self, kube_version):
 
         docs = render_chart(
             kube_version=kube_version,
-            show_only="templates/git-sync-relay/git-sync-relay-deployment.yaml",
+            show_only=[
+                "templates/git-sync-relay/git-sync-relay-deployment.yaml",
+                "templates/git-sync-relay/git-sync-relay-pvc.yaml",
+            ],
             values=values,
         )
         assert len(docs) == 1
@@ -291,7 +294,9 @@ def test_gsr_deployment_with_custom_probes(self, kube_version):
 
     def test_gsr_deployment_with_shared_volume(self, kube_version):
         """Test that a valid deployment is rendered when git-sync-relay is enabled."""
-        values = {"gitSyncRelay": {"enabled": True, "mode": "shared_volume"}}
+        values = {
+            "gitSyncRelay": {"enabled": True, "mode": "shared_volume", "volumeSync": {"storageClassName": "dollar-store-age"}}
+        }
 
         docs = render_chart(
             kube_version=kube_version,
@@ -303,10 +308,12 @@ def test_gsr_deployment_with_shared_volume(self, kube_version):
         )
         assert len(docs) == 2
         deployment, pvc = docs if docs[0]["kind"] == "Deployment" else docs[::-1]
-        # breakpoint()
         assert deployment["kind"] == "Deployment"
         assert deployment["apiVersion"] == "apps/v1"
         assert deployment["metadata"]["name"] == "release-name-git-sync-relay"
+        assert pvc["kind"] == "PersistentVolumeClaim"
+        assert pvc["kind"] == "PersistentVolumeClaim"
+        assert pvc["spec"]["storageClassName"] == "dollar-store-age"
         c_by_name = get_containers_by_name(deployment)
         assert not c_by_name.get("git-daemon")
         assert len(c_by_name) == 1