-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anyscale SDK updates #27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marwan116
force-pushed
the
iss-24/sdk-updates
branch
from
June 24, 2024 17:20
17bc28f
to
0fce162
Compare
marwan116
force-pushed
the
iss-24/sdk-updates
branch
from
June 24, 2024 17:21
0fce162
to
2f9fd8a
Compare
marwan116
force-pushed
the
iss-24/sdk-updates
branch
from
June 24, 2024 17:32
2f9fd8a
to
26ed59c
Compare
marwan116
force-pushed
the
iss-24/sdk-updates
branch
from
June 24, 2024 20:49
26ed59c
to
6ed721a
Compare
marwan116
force-pushed
the
iss-24/sdk-updates
branch
from
June 24, 2024 20:52
6ed721a
to
2397446
Compare
marwan116
force-pushed
the
iss-24/sdk-updates
branch
from
June 25, 2024 03:53
2397446
to
8db415d
Compare
marwan116
force-pushed
the
iss-24/sdk-updates
branch
from
June 25, 2024 05:10
c42df34
to
40b5a09
Compare
marwan116
force-pushed
the
iss-24/sdk-updates
branch
from
June 25, 2024 05:21
40b5a09
to
0b9d982
Compare
marwan116
force-pushed
the
iss-24/sdk-updates
branch
from
June 25, 2024 05:46
901ebef
to
29dfe61
Compare
marwan116
force-pushed
the
iss-24/sdk-updates
branch
from
June 25, 2024 06:43
8a02804
to
dc648c1
Compare
marwan116
force-pushed
the
iss-24/sdk-updates
branch
from
June 25, 2024 08:47
eb76455
to
ddf47cf
Compare
fix handling of service and job id and name attributes
marwan116
force-pushed
the
iss-24/sdk-updates
branch
from
June 25, 2024 16:42
cfb0436
to
8217944
Compare
marwan116
force-pushed
the
iss-24/sdk-updates
branch
from
June 25, 2024 16:54
8217944
to
f97eaff
Compare
- keep log fetching at trigger - default fetch_logs to true - remove heuristic to sleep
marwan116
force-pushed
the
iss-24/sdk-updates
branch
from
June 25, 2024 18:47
f97eaff
to
003a533
Compare
venkatajagannath
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24
The commits are structured to be self-contained and their titles to be descriptive of the changes performed