Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate GKEStartPodOperatorAsync #1464

Merged
merged 8 commits into from
Feb 18, 2024
Merged

deprecate GKEStartPodOperatorAsync #1464

merged 8 commits into from
Feb 18, 2024

Conversation

Lee-W
Copy link
Contributor

@Lee-W Lee-W commented Jan 30, 2024

Deprecate GKEStartPodOperatorAsync and proxy them to their Airflow OSS provider's counterpart.

This needs to wait for the fix of apache/airflow#37081

@Lee-W Lee-W force-pushed the deprecate-gke-operator branch 2 times, most recently from 48bd7fb to 19a4e80 Compare January 31, 2024 10:10
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (040e724) 98.27% compared to head (db236ae) 98.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1464      +/-   ##
==========================================
- Coverage   98.27%   98.25%   -0.03%     
==========================================
  Files          91       91              
  Lines        4648     4575      -73     
==========================================
- Hits         4568     4495      -73     
  Misses         80       80              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pankajkoti pankajkoti mentioned this pull request Feb 15, 2024
15 tasks
@Lee-W Lee-W marked this pull request as ready for review February 16, 2024 01:51
@Lee-W Lee-W force-pushed the deprecate-gke-operator branch 2 times, most recently from 639e693 to 77cb7dd Compare February 16, 2024 09:01
setup.cfg Outdated
@@ -53,15 +53,16 @@ apache.livy =
apache-airflow-providers-apache-livy>=3.7.1
paramiko
cncf.kubernetes =
apache-airflow-providers-cncf-kubernetes>=4
# TODO: Update version when below RC is released
apache-airflow-providers-cncf-kubernetes @https://files.pythonhosted.org/packages/a2/d5/aa6fb62804e9441b4cbddbdad85cfb5d7cba769b477e508871daaf483780/apache_airflow_providers_cncf_kubernetes-8.0.0rc1.tar.gz
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to test this with RC2 once out

setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this so that we can test our regressions DAGs together on all RCs and create a separate PR later to update the versions in setup.cfg to released versions from the current RCs

@pankajkoti pankajkoti merged commit 671aa93 into main Feb 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants