deprecate KubernetesPodOperatorAsync #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajastro
force-pushed
the
deprecate-KubernetesPodOperatorAsync
branch
from
b9d09bd
to
c3e372a
Compare
pankajastro
reviewed
Feb 12, 2024
| if self.do_xcom_push: | ||
| return result | ||
| self.logging_interval = logging_interval | ||
| super().__init__(deferrable=True, **kwargs) |
There was a problem hiding this comment.
we also need to pass logging_interval
There was a problem hiding this comment.
If it's present in the kwargs, it will be passed is. The default previous value here for logging_interval was None, and the upstream has default None too, so no additional care needs to be taken.
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1465 +/- ##
==========================================
+ Coverage 98.21% 98.28% +0.06%
==========================================
Files 91 91
Lines 4536 4485 -51
==========================================
- Hits 4455 4408 -47
+ Misses 81 77 -4 ☔ View full report in Codecov by Sentry. |
pankajkoti
reviewed
Feb 18, 2024
astronomer/providers/cncf/kubernetes/operators/kubernetes_pod.py
Outdated
Show resolved
Hide resolved
astronomer/providers/cncf/kubernetes/operators/kubernetes_pod.py
Outdated
Show resolved
Hide resolved
pankajkoti
approved these changes
Feb 18, 2024
pankajkoti
requested review from
phanikumv,
sunank200,
utkarsharma2 and
vatsrahul1001
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deperecate KubernetesPodOperatorAsync and proxy it to its OSS counterpart.
related: #1418