Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task to revoke ingress rule #1494

Merged
merged 7 commits into from
Mar 19, 2024
Merged

Add task to revoke ingress rule #1494

merged 7 commits into from
Mar 19, 2024

Conversation

pankajastro
Copy link
Contributor

@pankajastro pankajastro commented Mar 19, 2024

Add task to remove ingress rule

Screenshot 2024-03-19 at 4 08 35 PM

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (cde3421) to head (7958d60).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1494   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          94       94           
  Lines        4635     4635           
=======================================
  Hits         4558     4558           
  Misses         77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pankajastro pankajastro merged commit a6f8f8d into main Mar 19, 2024
11 checks passed
@pankajastro pankajastro deleted the revoke_ingress branch March 19, 2024 11:10
@pankajkoti
Copy link
Collaborator

SFTP DAG is failing for this newly added task in our stage deployment.

@pankajastro
Copy link
Contributor Author

SFTP DAG is failing for this newly added task in our stage deployment.

Aha, look like xcom key is not correct for sftp #1509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants