-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add task to revoke ingress rule #1494
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajastro
force-pushed
the
revoke_ingress
branch
from
March 19, 2024 08:24
0e3b9d9
to
1d33b50
Compare
pankajastro
force-pushed
the
revoke_ingress
branch
from
March 19, 2024 10:37
fdfdc33
to
bcc7ffa
Compare
pankajastro
requested review from
phanikumv,
pankajkoti,
Lee-W,
sunank200,
utkarsharma2 and
vatsrahul1001
as code owners
March 19, 2024 10:39
phanikumv
approved these changes
Mar 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1494 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 94 94
Lines 4635 4635
=======================================
Hits 4558 4558
Misses 77 77 ☔ View full report in Codecov by Sentry. |
SFTP DAG is failing for this newly added task in our stage deployment. |
Aha, look like xcom key is not correct for sftp #1509 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add task to remove ingress rule