Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-condition-for-cloning-system-tests #1578

Closed
wants to merge 1 commit into from

Conversation

vatsrahul1001
Copy link
Contributor

PR introduced a new step of cloning airflow and system test in a reusable wf here. As it is a reusable workflow it's used in astronomer-providers-logging wf which started failing also we do not need that step in logging providers tests. This PR address this issue by running step only when repo is astronomer-providers

Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels a bit odd to add a condition here to check if this workflow, which is already in this repo, is run from the same repo. If the workflow were stored in a shared location and referenced by multiple repos, the condition would make sense. For now, I think it would be better to copy the workflow to the logging provider repo where it's actually being used, rather than adding this condition here. What do you think?

@vatsrahul1001
Copy link
Contributor Author

It feels a bit odd to add a condition here to check if this workflow, which is already in this repo, is run from the same repo. If the workflow were stored in a shared location and referenced by multiple repos, the condition would make sense. For now, I think it would be better to copy the workflow to the logging provider repo where it's actually being used, rather than adding this condition here. What do you think?

I agree better would be to copy workflow to logging provider. I will close this PR and open a new one in logging provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants