Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PyTorch 1.3 #249

Merged
merged 5 commits into from
Nov 21, 2019
Merged

Support PyTorch 1.3 #249

merged 5 commits into from
Nov 21, 2019

Conversation

gpengzhi
Copy link
Collaborator

resolve #247
resolve #234
resolve #231

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #249 into master will decrease coverage by 0.05%.
The diff coverage is 86.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   83.09%   83.04%   -0.06%     
==========================================
  Files         192      195       +3     
  Lines       15196    15290      +94     
==========================================
+ Hits        12627    12697      +70     
- Misses       2569     2593      +24
Impacted Files Coverage Δ
texar/torch/data/data/__init__.py 100% <100%> (ø) ⬆️
texar/torch/data/data/data_iterators.py 81.88% <100%> (-2.77%) ⬇️
texar/torch/data/data/data_iterators_test.py 97.6% <100%> (-0.33%) ⬇️
texar/torch/data/data/data_iterators_utils.py 72.72% <72.72%> (ø)
texar/torch/data/data/sampler.py 90.44% <90.44%> (ø)
texar/torch/data/data/sampler_test.py 97.87% <97.87%> (ø)
texar/torch/core/layers.py 87.7% <0%> (-0.54%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2f4f95...4c6702e. Read the comment docs.

texar/torch/data/data/data_iterators.py Outdated Show resolved Hide resolved
@gpengzhi gpengzhi requested a review from huzecong November 20, 2019 23:49
@gpengzhi
Copy link
Collaborator Author

Tested on seq2seq_attn, gpt-2, and sentence_classifier examples.

Copy link
Collaborator

@huzecong huzecong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

.travis.yml Outdated Show resolved Hide resolved
@AvinashBukkittu
Copy link
Collaborator

Thanks for doing this! With new releases, Pytorch is making changes to a few attribute names in its core module, hence we end up making some updates to our data modules. LGTM.

@gpengzhi gpengzhi merged commit 53d8ead into asyml:master Nov 21, 2019
@gpengzhi gpengzhi deleted the PyTorch-1.3 branch February 4, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugs in data_iterators.py A (potential bug) in data module Support PyTorch 1.3.0 & Add it to CI
4 participants