Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set utf8 as default character encoding #272

Closed
wants to merge 2 commits into from
Closed

Set utf8 as default character encoding #272

wants to merge 2 commits into from

Conversation

imgaojun
Copy link
Contributor

Changing the default encoding to utf8 sounds good. I'm ok with that.
#270 #269

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #272 into master will decrease coverage by 0.28%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
- Coverage   83.04%   82.75%   -0.29%     
==========================================
  Files         195      195              
  Lines       15300    15300              
==========================================
- Hits        12706    12662      -44     
- Misses       2594     2638      +44
Impacted Files Coverage Δ
texar/torch/data/data/text_data_base.py 53.76% <ø> (ø) ⬆️
texar/torch/data/data_utils.py 43.75% <0%> (ø) ⬆️
texar/torch/data/vocabulary.py 83.69% <100%> (ø) ⬆️
texar/torch/data/data/data_iterators_utils.py 15.58% <0%> (-57.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08136b2...83fd495. Read the comment docs.

@gpengzhi gpengzhi requested a review from huzecong December 17, 2019 04:46
@imgaojun imgaojun closed this by deleting the head repository Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants