Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glee templates don't update to the latest version of Glee #923

Closed
fmvilas opened this issue Nov 24, 2023 · 6 comments · Fixed by asyncapi/.github#274
Closed

Glee templates don't update to the latest version of Glee #923

fmvilas opened this issue Nov 24, 2023 · 6 comments · Fixed by asyncapi/.github#274
Labels
bug Something isn't working

Comments

@fmvilas
Copy link
Member

fmvilas commented Nov 24, 2023

Describe the bug

When a new version of Glee is out, the @asyncapi/glee dependency is updated but the @asyncapi/glee dependency of the Glee templates is not.

Expected behavior

It should update automatically when a new version of Glee is out.

@fmvilas fmvilas added the bug Something isn't working label Nov 24, 2023
@MahendraDani
Copy link

@fmvilas Would you please guide me how can this issue be solved?

@fmvilas
Copy link
Member Author

fmvilas commented Nov 27, 2023

I think either @KhudaDad414 or @derberg can guide you better. I'm not fully aware of how CI works.

@KhudaDad414
Copy link
Member

@MahendraDani we use https://github.com/asyncapi/.github/blob/master/.github/workflows/bump.yml workflow to update the package of dependent projects. which in turn uses https://github.com/derberg/npm-dependency-manager-for-your-github-org which is developed by @derberg to update the dependent packages. not sure if it is something that this action is designed to do. I mean update packages in custom paths. 🤔

@Shurtu-gal
Copy link
Collaborator

@fmvilas @KhudaDad414 I guess this issue can be shifted to @derberg's action.
Found the error ⬇️

https://github.com/derberg/npm-dependency-manager-for-your-github-org/blob/26a4f13d740254719971325046822a169aaa7441/lib/api-calls.js#L8-L10

The action is getting a correct list of file paths however as the repos are grouped a repo with multiple hits has some file paths which are ignored.

This can be seen here which only lists 4 repos leading to an update of only 4 filepaths. While this rest API call lists 17 of them.

If you want I can raise an issue and resolve it at the action level 🤟🏻

Copy link
Member

derberg commented Dec 19, 2023

@Shurtu-gal please go ahead 🙏

@Shurtu-gal
Copy link
Collaborator

@Shurtu-gal please go ahead 🙏

derberg/npm-dependency-manager-for-your-github-org#15
Done 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants