Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle multiple package.json in single repo #15

Merged
merged 3 commits into from
Feb 21, 2024
Merged

feat: handle multiple package.json in single repo #15

merged 3 commits into from
Feb 21, 2024

Conversation

Shurtu-gal
Copy link
Contributor

Description

  • Currently the search api was returning multiple items for multiple package.json which were being removed upon filtering.
  • This PR improves the action by grouping the filepaths into an array and bumping version in each filepath.
  • Further information can be found here

Issues fixed

Fixes #14

@Shurtu-gal Shurtu-gal mentioned this pull request Dec 20, 2023
Closed
@Shurtu-gal
Copy link
Contributor Author

Shurtu-gal commented Dec 21, 2023 •
edited
Loading

@derberg Successful workflow run can be found here with this PR

@derberg derberg changed the title fix: handle multiple package.json in single repo feat: handle multiple package.json in single repo Feb 21, 2024
derberg
derberg approved these changes Feb 21, 2024
View reviewed changes
Copy link
Owner

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing job mate, nothing to add from my side!

@derberg derberg merged commit 3df56be into derberg:main Feb 21, 2024
@Shurtu-gal Shurtu-gal deleted the fix/duplicates branch February 21, 2024 15:57
@derberg
Copy link
Owner

derberg commented Feb 21, 2024

@Shurtu-gal to use it in Glee and other projects in AsyncAPI, remember you need to update proper workflow in asyncapi/.github repo

@Shurtu-gal
Copy link
Contributor Author

Sure, @derberg I will do it as soon as my exams end.

@Shurtu-gal Shurtu-gal mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Action is not working with multi-project repos
2 participants
@Shurtu-gal @derberg