Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added presets for JavaFileGenerator #1039

Merged
merged 4 commits into from
Jan 15, 2024
Merged

feat: added presets for JavaFileGenerator #1039

merged 4 commits into from
Jan 15, 2024

Conversation

Athul0491
Copy link
Contributor

Description

  • This PR adds presets to the JavaFileGenerator in the generate models command.
  • This would ensure that the java model classes are generated correctly even if java naming conventions are not followed.

Related issue(s)
Resolves #1038

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@oliverkuntze
Copy link

Any chance that someone has the time to review this? We are desperately waiting for this fix. :-)

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Souvikns
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit a53bb17 into asyncapi:master Jan 15, 2024
10 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants