Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build : Added pacote dependency with error handling #1320

Closed
wants to merge 5 commits into from

Conversation

rajRishi22
Copy link

Solves the issue #1102
Updates done :

  1. Added pacote dependency with its latest version.
  2. Modified generator.js file.
  3. cleaned mocks and add new one .

Copy link

changeset-bot bot commented Nov 14, 2024

⚠️ No Changeset found

Latest commit: 0bc5f9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Nov 14, 2024

We require all PRs to follow Conventional Commits specification.
More details 👇🏼

 No release type found in pull request title "build : Added pacote dependency with error handling ". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@rajRishi22 rajRishi22 changed the title fix : Improved arborist (npm installation) to have no hacks build : Added pacote dependency with error handling Nov 15, 2024
@derberg
Copy link
Member

derberg commented Nov 18, 2024

@rajRishi22 Hi, thanks a lot for your engagement, but if you want to really help the project and learn something, we need more proactiveness from you. When you open a PR, go back to if after few minutes to see what bots say about it.
You did not followup to comments from asyncapi-bot, sonarcloud. I also see you most probably did not read development guide and for example did not run linter to make sure your PR has a good quality.

I will close this PR. We are happy to accept your contribution, you just need to first go through first PR that tried to fix this issue, see what had to be added, what was missing, and see entire conversation about the topic -> #1287

Once all above is done, please open a new PR

Cheers 🍻

@derberg derberg closed this Nov 18, 2024
@rajRishi22
Copy link
Author

@derberg Hi , Thanks for pointing out the issues in this PR, it will help me for sure . I will make sure to be more proactive from now on and submit another PR that solves all the issues pointed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants