fix: remove double None from Pydantic preset

asyncapi · Feb 14, 2025 · 1dca3f0 · 1dca3f0
1 parent 8db1b03
commit 1dca3f0
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 17 deletions.
diff --git a/examples/generate-python-pydantic-models/__snapshots__/index.spec.ts.snap b/examples/generate-python-pydantic-models/__snapshots__/index.spec.ts.snap
@@ -5,9 +5,9 @@ Array [
   "class Root(BaseModel): 
   optional_field: Optional[str] = Field(description='''this field is optional''', default=None, default=None)
   required_field: str = Field(description='''this field is required''')
-  no_description: Optional[str] = Field(default=None, default=None)
-  options: Optional[Options.Options] = Field(default=None, default=None)
-  content_type: Optional[str] = Field(default=None, default=None)
+  no_description: Optional[str] = Field(default=None)
+  options: Optional[Options.Options] = Field(default=None)
+  content_type: Optional[str] = Field(default=None)
 ",
 ]
 `;

diff --git a/src/generators/python/presets/Pydantic.ts b/src/generators/python/presets/Pydantic.ts
@@ -59,9 +59,6 @@ const PYTHON_PYDANTIC_CLASS_PRESET: ClassPresetType<PythonOptions> = {
     ) {
       decoratorArgs.push('exclude=True');
     }
-    if (!property.required) {
-      decoratorArgs.push('default=None');
-    }
 
     return `${propertyName}: ${type} = Field(${decoratorArgs.join(', ')})`;
   },

diff --git a/test/generators/python/presets/__snapshots__/Pydantic.spec.ts.snap b/test/generators/python/presets/__snapshots__/Pydantic.spec.ts.snap
@@ -4,7 +4,7 @@ exports[`PYTHON_PYDANTIC_PRESET should render nullable union 1`] = `
 Array [
   "class NullableUnionTest(BaseModel): 
   nullable_union_test: Optional[Union[Union1.Union1]] = Field(default=None)
-  additional_properties: Optional[dict[str, Any]] = Field(default=None, exclude=True, default=None)
+  additional_properties: Optional[dict[str, Any]] = Field(default=None, exclude=True)
 
   @model_serializer(mode='wrap')
   def custom_serializer(self, handler):
@@ -40,8 +40,8 @@ Array [
 
 ",
   "class Union1(BaseModel): 
-  test_prop1: Optional[str] = Field(default=None, default=None)
-  additional_properties: Optional[dict[str, Any]] = Field(default=None, exclude=True, default=None)
+  test_prop1: Optional[str] = Field(default=None)
+  additional_properties: Optional[dict[str, Any]] = Field(default=None, exclude=True)
 
   @model_serializer(mode='wrap')
   def custom_serializer(self, handler):
@@ -84,8 +84,8 @@ exports[`PYTHON_PYDANTIC_PRESET should render pydantic for class 1`] = `
   prop: Optional[str] = Field(description='''test
     multi
     line
-    description''', default=None, default=None)
-  additional_properties: Optional[dict[str, Any]] = Field(default=None, exclude=True, default=None)
+    description''', default=None)
+  additional_properties: Optional[dict[str, Any]] = Field(default=None, exclude=True)
 
   @model_serializer(mode='wrap')
   def custom_serializer(self, handler):
@@ -125,8 +125,8 @@ exports[`PYTHON_PYDANTIC_PRESET should render pydantic for class 1`] = `
 exports[`PYTHON_PYDANTIC_PRESET should render union to support Python < 3.10 1`] = `
 Array [
   "class UnionTest(BaseModel): 
-  union_test: Optional[Union[Union1.Union1, Union2.Union2]] = Field(default=None, default=None)
-  additional_properties: Optional[dict[str, Any]] = Field(default=None, exclude=True, default=None)
+  union_test: Optional[Union[Union1.Union1, Union2.Union2]] = Field(default=None)
+  additional_properties: Optional[dict[str, Any]] = Field(default=None, exclude=True)
 
   @model_serializer(mode='wrap')
   def custom_serializer(self, handler):
@@ -162,8 +162,8 @@ Array [
 
 ",
   "class Union1(BaseModel): 
-  test_prop1: Optional[str] = Field(default=None, default=None)
-  additional_properties: Optional[dict[str, Any]] = Field(default=None, exclude=True, default=None)
+  test_prop1: Optional[str] = Field(default=None)
+  additional_properties: Optional[dict[str, Any]] = Field(default=None, exclude=True)
 
   @model_serializer(mode='wrap')
   def custom_serializer(self, handler):
@@ -199,8 +199,8 @@ Array [
 
 ",
   "class Union2(BaseModel): 
-  test_prop2: Optional[str] = Field(default=None, default=None)
-  additional_properties: Optional[dict[str, Any]] = Field(default=None, exclude=True, default=None)
+  test_prop2: Optional[str] = Field(default=None)
+  additional_properties: Optional[dict[str, Any]] = Field(default=None, exclude=True)
 
   @model_serializer(mode='wrap')
   def custom_serializer(self, handler):