Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the shop link from footer #2168

Merged
merged 4 commits into from
Feb 8, 2025

Conversation

neoandmatrix
Copy link
Contributor

Description

This PR introduces the changes to remove the shop link from the website footer.

Related Issue

Resolves #2166

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

After removing the shop link below is the final output.

image

@devilkiller-ag please review.
Thanks.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 3227fb8
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/67a7262ad7d7740008341e60

Copy link
Member

@devilkiller-ag devilkiller-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Thanks @neoandmatrix for opening the PR.

@coveralls
Copy link

coveralls commented Jan 29, 2025

Pull Request Test Coverage Report for Build 13214381840

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.402%

Totals Coverage Status
Change from base Build 13214332001: 0.0%
Covered Lines: 6475
Relevant Lines: 6870

💛 - Coveralls

@devilkiller-ag
Copy link
Member

The failing blackbox test is unrelated to changes made in this PR so I am merging this PR.
/rtm

@jonaslagoni jonaslagoni changed the title fix: remove the shop link from footer chore: remove the shop link from footer Feb 8, 2025
@jonaslagoni jonaslagoni merged commit d37432b into asyncapi:master Feb 8, 2025
4 checks passed
Copy link

sonarqubecloud bot commented Feb 8, 2025

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Remove store link from the website footer
5 participants