Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make the code base easier to understand #82

Merged
merged 5 commits into from
Mar 1, 2022

Conversation

KhudaDad414
Copy link
Member

Description

  • Remove the extra JSDOC documentations that contribute nothing and make the code base harder to grasp.
  • convert arrow functions to member functions in classes.

@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@KhudaDad414 KhudaDad414 changed the title chore: make to code base easier to understand chore: make the code base easier to understand Feb 22, 2022
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, great job! :)

@@ -1,8 +1,12785 @@
{
"name": "@asyncapi/optimizer",
"version": "0.1.2",
"lockfileVersion": 2,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have in mind that we don't support lockVersion: 2 in the workflows. More info asyncapi/.github#123 It's not a big problem but some things in our workflows may not work as we would like. We need to monitor this and keep it in mind. Of course, it's not a problem that precludes us from merging this PR :) Good work!

@KhudaDad414
Copy link
Member Author

/rtm

@KhudaDad414
Copy link
Member Author

/dnm

@asyncapi-bot asyncapi-bot merged commit b436377 into asyncapi:master Mar 1, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants