Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert changes to spec that were wrongly applied #1489

Merged
merged 4 commits into from
Apr 5, 2023

Conversation

derberg
Copy link
Member

@derberg derberg commented Apr 4, 2023

fixing bug related to asyncapi/spec#921

what I did was basically copy/paste a spec from release candidate before it was broken by #1482

@alequetzalli please approve and merge 🙏🏼

@netlify
Copy link

netlify bot commented Apr 4, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cbc5533
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/642cd2cf21cc6500089a9774
😎 Deploy Preview https://deploy-preview-1489--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 39
🟠 Accessibility 88
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1489--asyncapi-website.netlify.app/

@quetzalliwrites quetzalliwrites merged commit b9b96b2 into asyncapi:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants