fix: fixes gap between Github & View Docs Button on smaller screens (#3008) #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…syncapi#3008) Signed-off-by: Chandan-6 <[email protected]> * Added Vertical Spacing * Set `view docs` content width to fit. ( So that only occupies width as per the content )
ChandanKhamitkar
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
ChandanKhamitkar
changed the title
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on undefined |
Mayaleeeee
requested changes
Sep 24, 2024
There was a problem hiding this comment.
Thanks for reporting the issue @Chandan-6
I can see it from here, too.
- Please add a spacing of
24pxbetween the two buttons. - Please do not reduce the size of the
View Docsbutton; leave it as it is. - Let's increase the size of the
View on GitHubbutton to the same size asView Docs. I'd like you to see what it looks like.
|
Closing this as this issue is under bounty program |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On smaller screens the buttons were not properly aligned and having spacing issues.
view docscontent width to fit. ( So that only occupies width as per the content )Before
After ✅
Resolves: #3008