Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Success checking #378

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Success checking #378

merged 2 commits into from
Jul 5, 2024

Conversation

atesgoral
Copy link
Owner

@atesgoral atesgoral commented Jul 5, 2024

Increase run-per-level count from 10 to 100 since these run pretty fast.

Instead of just reporting pass rate and moving on, start failing levels when they're not marked as specific and don't pass 100% of runs.

Example output (for this PR) showing a case where a 71% pass rate is deemed acceptable because the solution is marked as specific: https://github.com/atesgoral/hrm-solutions/actions/runs/9802974314/job/27068439475#step:4:21

Rename failing solutions to .asm.skip for now, for triaging:

  • Some solutions may have been miscategorized. We may need to extend the file naming scheme to be able to add more than one tag (e.g. "nn.nn.obsolete.specific.author-name.asm")
  • The hrm-level-outbox-generator and hrm-level-inbox-generator packages might themselves have issues and need to be audited.

The unit tests have no value unless we start failing CI on PRs with incomplete or miscategorized solutions.

level: level,
source: source,
program: program,
level,
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just modernizing the code as I touch things.

@clarfonthey
Copy link
Collaborator

Looks reasonable to me. The game's handling of solutions is kind of weird, so, being able to have actual random tests is nice.

@atesgoral atesgoral merged commit a0dae4f into main Jul 5, 2024
1 check passed
@atesgoral atesgoral deleted the atesgoral/success-checking branch July 5, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants