Merge pull request #308 from kinke/fix_j

Fix -j behavior
atilaneves · Jan 23, 2024 · b362027 · b362027
2 parents 6bc35df + 7979360
commit b362027
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/subpackages/runner/source/unit_threaded/runner/options.d b/subpackages/runner/source/unit_threaded/runner/options.d
@@ -57,7 +57,7 @@ struct Options {
             numThreads = 1; // let -s override -j
 
         if (numThreads == 0)
-            numThreads = totalCPUs - 1;
+            numThreads = totalCPUs;
 
         exit =  help || list;
     }

diff --git a/subpackages/runner/source/unit_threaded/runner/testsuite.d b/subpackages/runner/source/unit_threaded/runner/testsuite.d
@@ -166,9 +166,9 @@ private:
 
         _stopWatch.start();
 
-        if (_options.numThreads != 1) {
+        if (_options.numThreads > 1) {
             // use a dedicated task pool with non-daemon worker threads
-            auto taskPool = new TaskPool(_options.numThreads);
+            auto taskPool = new TaskPool(_options.numThreads - 1); // main thread is used too
             _failures = reduce!((a, b) => a ~ b)(_failures, taskPool.amap!runTest(tests));
             taskPool.finish(/*blocking=*/false);
         } else {