-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update raid bosses #8
Open
klablabla
wants to merge
283
commits into
atis:master
Choose a base branch
from
klablabla:patch-17
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add start_time and moved time slot values to config.php Add 60 extra seconds for the voting button (see comment in the file) Add a "last chance to start a raid" time (can be configured in config.php) to display another time voting button when there is still plenty of time but normal configuration of time slots wouldn't allow another voting button. Example: Timeslot: 15min, Last Start before raid ends: 10min, Raid ends: 18:24, Last shown voting option would be 18:00 without my additional button (still 24min left!) and 18:14 with my additional button (18:24 - 10min). Improved layout of the telegram message (hope you like it - it's almost the same layout that MR uses for our raids here in town) and added a "raids starts at hh:ii" message for raids where the egg is not open yet (but the countdown is running) with the ability to already vote even though the raid has not started yet (one of my favorite improvements) Get rid of several "undefined index", "undefined constants", etc. notices in the log files. Some minor adjustments and fixes
Send message back when raid got updated.
…itted gym_name and if a database entry was found it checks If the end_time of the new raid is between minus/plus 5 minutes of raid we got from the database. Based on result it creates a new raid or updates an existing raid (currently updates raid boss and gym team). New gyms which are not in the database yet will be handled for sure and don't lead to errors. Additionally added a rounding option to the nearest 5 minutes for the last start / voting option of the raid, so e.g. 11:14 is now rounded to 11:15. Unfortunately this will sometimes decrease the amount of time left, e.g. from 10 minutes (11:14 - 11:24) to 9 minutes (11:15 - 11:24), but makes voting times "beautiful" again :D Last but not least a little undefined $tl_msg issue I missed last time was fixed :)
Additional functions, several fixes and improvements
…r parameters Add offset parsing for not yet hatched eggs based on fixed duration removed update message for "egg hatched" raid boss update. Unnecessary, unless the real message gets updates without a user side refresh
Minor fixes for pre-hatch polls
Fix some spacings
…nged a little description to make input parameters a bit clearer
…not good but should be fixable ;)
Done via github (prior edit was on console/command line)
remove unnecessary RAID_DURATION
Readme and raid.php improvements
Fixed little issue with undefined index
Added config variable to send location message or just the raid poll message. Fixed undefined index by adding $nick in logic.php
…unction for Ex-Raid raid polls which are usually created a few days before the Ex-Raid
…maybe needed to work with gomap-notifier
… maybe limited to 100 gyms[C due to amount of inline keys by telegram
Improvements and fixes to the new pokemon keys feature
…icate votes from the same person at the same raid
Switch gym selection and location at the start
Fix attendance bug
Improve improve improve :D
…get added once translation is there
…for ex-raid date and time selection
Update constants.php
Create ex-raids via telegram
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.