Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check existing location tokens on unconditioned model #50

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Check existing location tokens on unconditioned model #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Model/File.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ protected function init(): void
$this->onHookShort(Model::HOOK_AFTER_DELETE, function () {
$path = $this->get('location');
if ($path && $this->flysystem->fileExists($path)) {
$files = (clone $this->getModel())->addCondition(
$files = (new self($this->getModel()->getPersistence()))->addCondition(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not ok as model can be extended/modified

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mvorisek Thank you for your note, but do not understand what you mean: we need to check unconditioned if other tokens exist with the same location. How do we then accomplish this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related with atk4/data#1054

'id',
'!=',
$this->getId()
Expand Down