Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLH-107 : (feat) Add metrics for the bulk entity creation for more observability #4157

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

sumandas0
Copy link

Change description

Needed to add few metrics for entity bulk flow to get latency details by functions for https://atlanhq.atlassian.net/browse/MLH-106

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@aarshi0301
Copy link

Actual delta is small, but see lot of formatting

@sumandas0
Copy link
Author

Actual delta is small, but see lot of formatting

Yeah cause of putting them inside try/finally block

@sumandas0 sumandas0 merged commit ee5cdc3 into master Feb 11, 2025
9 of 11 checks passed
@sumandas0 sumandas0 deleted the mlh-107-bulk-metrics branch February 11, 2025 13:51
Copy link

@nikhilbonte21 nikhilbonte21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ensure metic names are not duplicated with any existing metrics
Names seems to be little generic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants