Set-up turbo repo and move towards ahead of time compiled files #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the v2/v3 test setup so that tests that are skipped for V3 run. A subsequent change will improve our logging to automatically diff the outputs of both versions in a single process. The idea here is to easily identify tests that are green but skipped, as well as get a grasp of current failures.
This allows us to run integration tests that fail without crashing the process.
Since we do not have cache invalidation properly set-up with the rust implementation. It's better to force it for now. This should, if our implementation is correct fix certain tests that depend on cache invalidation.
Since we do not have cache invalidation properly set-up with the rust implementation. It's better to force it for now. This should, if our implementation is correct fix certain tests that depend on cache invalidation.
| @@ -361,7 +361,9 @@ impl ResolverPlugin for AtlaspackResolver { | |||
| (atlaspack_resolver::Resolution::External, _query) => { | |||
| if let Some(_source_path) = &ctx.dependency.source_path { | |||
| if ctx.dependency.env.is_library && ctx.dependency.specifier_type != SpecifierType::Url { | |||
| todo!("check excluded dependency for libraries"); | |||
| return Err(anyhow::anyhow!( | |||
There was a problem hiding this comment.
Is this meant to be here? Also a lot of the checks for this code path in the JS version seem a bit overkill to me 🤷
| @@ -130,7 +130,7 @@ export default class Atlaspack { | |||
| rustAtlaspack = new AtlaspackV3({ | |||
| ...options, | |||
| corePath: path.join(__dirname, '..'), | |||
| threads: process.env.NODE_ENV === 'test' ? 2 : undefined, | |||
| threads: process.env.NODE_ENV === 'test' ? 0 : undefined, | |||
| @@ -11,10 +11,10 @@ import { | |||
| } from '@atlaspack/test-utils'; | |||
| import type {BundleGraph, BundleGroup, PackagedBundle} from '@atlaspack/types'; | |||
|
|
|||
| describe.v2('BundleGraph', () => { | |||
| describe('BundleGraph', () => { | |||
There was a problem hiding this comment.
All these test changes should be in a separate PR to reduce noise, including the join / removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #99