Apply suggestions from code review

Co-authored-by: Franklin Wang <[email protected]>
atlassian-labs · Dec 18, 2023 · 19328d1 · 19328d1
1 parent d242d24
commit 19328d1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/lib/src/main/java/graphql/nadel/engine/blueprint/NadelExecutionBlueprintFactory.kt b/lib/src/main/java/graphql/nadel/engine/blueprint/NadelExecutionBlueprintFactory.kt
@@ -269,10 +269,6 @@ private class Factory(
         )
     }
 
-    private fun getHydrationCondition(): NadelHydrationWhenCondition? {
-        return null
-    }
-
     private fun getHydrationCondition(hydration: UnderlyingServiceHydration): NadelHydrationWhenCondition? {
         if (hydration.conditionalHydration == null) {
             return null
@@ -286,7 +282,7 @@ private class Factory(
         if (hydration.conditionalHydration.predicate.startsWith != null) {
             return NadelHydrationWhenCondition.StringResultStartsWith(
                 fieldPath = NadelQueryPath(hydration.conditionalHydration.sourceField),
-                value = hydration.conditionalHydration.predicate.startsWith
+                prefix = hydration.conditionalHydration.predicate.startsWith
             )
         }
         if (hydration.conditionalHydration.predicate.matches != null) {

diff --git a/lib/src/main/java/graphql/nadel/engine/blueprint/hydration/NadelHydrationWhenCondition.kt b/lib/src/main/java/graphql/nadel/engine/blueprint/hydration/NadelHydrationWhenCondition.kt
@@ -25,7 +25,7 @@ sealed class NadelHydrationWhenCondition {
 
     data class StringResultStartsWith(
         val fieldPath: NadelQueryPath,
-        val value: String,
+        val prefix: String,
     ) : NadelHydrationWhenCondition() {
         override fun evaluate(resultId: String): Boolean {
             TODO("Not yet implemented")