Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add user context to a hook #466

Merged
merged 1 commit into from
Oct 30, 2023
Merged

add user context to a hook #466

merged 1 commit into from
Oct 30, 2023

Conversation

temaEmelyan
Copy link
Member

Please make sure you consider the following:

  • Add tests that use __typename in queries
  • Does this change work with all nadel transformations (rename, type rename, hydration, etc)? Add tests for this.
  • Is it worth using hints for this change in order to be able to enable a percentage rollout?
  • Do we need to add integration tests for this change in the graphql gateway?
  • Do we need a pollinator check for this?

@temaEmelyan temaEmelyan changed the title add user context to a-hook add user context to a hook Oct 27, 2023
gnawf
gnawf approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@gnawf gnawf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@temaEmelyan temaEmelyan merged commit 6d5cf42 into master Oct 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnawf gnawf gnawf approved these changes

@bbakerman bbakerman Awaiting requested review from bbakerman

@sbarker2 sbarker2 Awaiting requested review from sbarker2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@temaEmelyan @gnawf