Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull graphql-java with oneof fix and add more tests #467

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

felipe-gdr
Copy link
Contributor

Please make sure you consider the following:

  • [n ] Add tests that use __typename in queries
  • [n ] Does this change work with all nadel transformations (rename, type rename, hydration, etc)? Add tests for this.
  • [n ] Is it worth using hints for this change in order to be able to enable a percentage rollout?
  • [y ] Do we need to add integration tests for this change in the graphql gateway?
  • [n ] Do we need a pollinator check for this?

@atlassian-cla-bot
Copy link

atlassian-cla-bot bot commented Oct 30, 2023

Hooray! All contributors have signed the CLA.

Copy link
Collaborator

@gnawf gnawf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@felipe-gdr felipe-gdr merged commit 8bc3a66 into master Nov 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants