Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete dead code and better test name #481

Merged
merged 1 commit into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions test/src/test/kotlin/graphql/nadel/tests/EngineTestHook.kt
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,7 @@ internal fun getTestHook(fixture: TestFixture): EngineTestHook? {
"new batch polymorphic hydration with rename",
"new batch polymorphic hydration when hook returns null 1",
"new batch polymorphic hydration actor fields are in the same service return types implement same interface",
"new complex-identified-by-with-rename",
"new new batching single source id",
"new new batching multiple source ids going to different services",
"new complex identified by with rename",
->
name.removePrefix("new ")
else -> name
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "complex-identified-by-with-rename"
name: "complex identified by with rename"
enabled: true
overallSchema:
UserService: |
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: "new complex-identified-by-with-rename"
name: "new complex identified by with rename"
enabled: true
overallSchema:
# language=GraphQL
UserService: |
type Query {
users(id: [UserInput]): [User]
Expand All @@ -13,6 +14,7 @@ overallSchema:
id: ID
name: String
}
# language=GraphQL
Issues: |
type Query {
issues: [Issue]
Expand All @@ -31,6 +33,7 @@ overallSchema:
)
}
underlyingSchema:
# language=GraphQL
UserService: |
type Query {
users(id: [UserInputUnderlying]): [User]
Expand All @@ -46,6 +49,7 @@ underlyingSchema:
siteId: ID
name: String
}
# language=GraphQL
Issues: |
type Query {
issues: [Issue]
Expand All @@ -60,6 +64,7 @@ underlyingSchema:
authorId: UserRef
id: ID
}
# language=GraphQL
query: |
query {
issues {
Expand All @@ -74,6 +79,7 @@ variables: { }
serviceCalls:
- serviceName: "Issues"
request:
# language=GraphQL
query: |
query {
issues {
Expand Down Expand Up @@ -155,6 +161,7 @@ serviceCalls:
}
- serviceName: "UserService"
request:
# language=GraphQL
query: |
query ($v0: [UserInputUnderlying]) {
users(id: $v0) {
Expand Down Expand Up @@ -201,6 +208,7 @@ serviceCalls:
}
- serviceName: "UserService"
request:
# language=GraphQL
query: |
query ($v0: [UserInputUnderlying]) {
users(id: $v0) {
Expand Down
Loading