Fix validation and outdated schema problem #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnawf
commented
Dec 17, 2023
| @@ -223,7 +223,10 @@ object NadelDirectives { | |||
| val identifiedByValues = resolveArgumentValue<List<Any>>(inputIdentifiedBy) | |||
| val identifiedBy = createObjectIdentifiers(identifiedByValues) | |||
|
|
|||
| val conditionalHydration = buildConditionalHydrationObject(directive.getArgument("when"))?.result | |||
| val conditionalHydration = directive.getArgument("when") | |||
| ?.let { | |||
There was a problem hiding this comment.
Handle case where schema does not define when and the value is null.
There was a problem hiding this comment.
makes sense, thanks for picking it up 👍
| ) | ||
| } | ||
| val whenConditionSourceFieldTypeName: String = (whenConditionSourceField.type as GraphQLScalarType).name |
There was a problem hiding this comment.
Avoid manual casting. There is a bug where a non-nullable type causes this to crash.
There was a problem hiding this comment.
Thanks for fixing this 👍
sbarker2
approved these changes
Dec 17, 2023
sbarker2
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.