Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrapper classes for Nadel directives #601

Merged
merged 9 commits into from
Nov 4, 2024
Merged

Add wrapper classes for Nadel directives #601

merged 9 commits into from
Nov 4, 2024

Conversation

gnawf
Copy link
Collaborator

@gnawf gnawf commented Oct 21, 2024

So this PR adds a bunch of wrapper classes around GraphQLAppliedDirective to model the @hydrated and @renamed definitions etc.

So you can write code like field.getHydrations().first().backingField etc.

Also deleted @hydratedFrom because nobody uses that.

We'll revisit it later because we do want to make hydration definitions easier.

felipe-gdr
felipe-gdr previously approved these changes Oct 23, 2024
Base automatically changed from virtual-fields to master October 31, 2024 02:16
@gnawf gnawf dismissed felipe-gdr’s stale review October 31, 2024 02:16

The base branch was changed.

@gnawf gnawf changed the title Refactor dsl code Add wrapper classes for Nadel directives Nov 1, 2024
@gnawf gnawf requested a review from felipe-gdr November 1, 2024 03:39
felipe-gdr
felipe-gdr previously approved these changes Nov 3, 2024
Copy link
Contributor

@felipe-gdr felipe-gdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@gnawf gnawf merged commit fe005a5 into master Nov 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants