[AXON 95] Fix file attachment to jira tickets #93
+145
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcomura
requested review from
bwieger-atlassian-com,
sdzh-atlassian and
cabella-dot
as code owners
marcomura
changed the title
sdzh-atlassian
previously approved these changes
Feb 6, 2025
bwieger-atlassian-com
previously approved these changes
Feb 6, 2025
…ON-95-unable-to-attach-files-when-creating-a-jira-cloud
marcomura
dismissed stale reviews from bwieger-atlassian-com and sdzh-atlassian
via
4e7a81f
bwieger-atlassian-com
approved these changes
Feb 6, 2025
I believe it's already "best" 😆 |
marcomura
deleted the
AXON-95-unable-to-attach-files-when-creating-a-jira-cloud
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root of the issue was the inability to retrieve the absolute path of the picked file from the file picker, which probably it's done for security reasons, and the subsequent attempt to read the file from a path that we don't have.
Originally, the file was read from the controller, which receives the file info from the view via post message.
After the fix, the file is read by the view before the post message, and the controller receives the file content along with the file metadata.
Tested: