NONE: remove FF (#2569)

Co-authored-by: Gary Xue <[email protected]>

src/config/feature-flags.ts

@@ -30,7 +30,6 @@ export enum BooleanFlags {
 export enum StringFlags {
 	BLOCKED_INSTALLATIONS = "blocked-installations",
 	LOG_LEVEL = "log-level",
-	HEADERS_TO_ENCRYPT = "headers-to-encrypt",
 	SEND_ALL = "send-all"
 }
 
@@ -40,7 +39,6 @@ export enum NumberFlags {
 	PREEMPTIVE_RATE_LIMIT_THRESHOLD = "preemptive-rate-limit-threshold",
 	NUMBER_OF_BUILD_PAGES_TO_FETCH_IN_PARALLEL = "number-of-build-to-fetch-in-parallel",
 	BACKFILL_PAGE_SIZE = "backfill-page-size",
-	BACKFILL_MAX_SUBTASKS = "backfill-max-subtasks",
 	INSTALLATION_TOKEN_CACHE_MAX_SIZE = "installation-token-cache-max-size"
 }
 

src/sync/branch.test.ts

@@ -133,6 +133,7 @@ describe("sync/branches", () => {
 				.create();
 
 			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 
 		});
 
@@ -293,6 +294,7 @@ describe("sync/branches", () => {
 			gitHubServerApp = builderResult.gitHubServerApp!;
 
 			gheUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			gheUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 		});
 
 		const makeExpectedResponse = async (branchName: string) => {

src/sync/build.test.ts

@@ -81,6 +81,7 @@ describe("sync/builds", () => {
 	it("should sync builds to Jira when build message contains issue key", async () => {
 		const data: BackfillMessagePayload = { installationId: DatabaseStateCreator.GITHUB_INSTALLATION_ID, jiraHost };
 
+		githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 		githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 		githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 
@@ -137,6 +138,7 @@ describe("sync/builds", () => {
 	it("should not explode when returned payload doesn't have head_commit", async () => {
 		const data: BackfillMessagePayload = { installationId: DatabaseStateCreator.GITHUB_INSTALLATION_ID, jiraHost };
 
+		githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 		githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 		githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 
@@ -202,6 +204,7 @@ describe("sync/builds", () => {
 			expect.anything(),
 			expect.anything()
 		).mockResolvedValue(NUMBER_OF_PARALLEL_FETCHES);
+		githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 
 		const data: BackfillMessagePayload = { installationId: DatabaseStateCreator.GITHUB_INSTALLATION_ID, jiraHost };
 
@@ -224,6 +227,7 @@ describe("sync/builds", () => {
 
 		const data: BackfillMessagePayload = { installationId: DatabaseStateCreator.GITHUB_INSTALLATION_ID, jiraHost };
 
+		githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 		githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 		githubNock
 			.get(`/repos/integrations/test-repo-name/actions/runs?per_page=20&page=6`)
@@ -236,6 +240,7 @@ describe("sync/builds", () => {
 	it("should sync multiple builds to Jira when they contain issue keys", async () => {
 		const data: BackfillMessagePayload = { installationId: DatabaseStateCreator.GITHUB_INSTALLATION_ID, jiraHost };
 
+		githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 		githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 		githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 
@@ -306,6 +311,7 @@ describe("sync/builds", () => {
 	it("should not call Jira if no issue keys are present", async () => {
 		const data: BackfillMessagePayload = { installationId: DatabaseStateCreator.GITHUB_INSTALLATION_ID, jiraHost };
 
+		githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 		githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 		githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 
@@ -329,6 +335,7 @@ describe("sync/builds", () => {
 	it("should not call Jira if no data is returned", async () => {
 		const data: BackfillMessagePayload = { installationId: DatabaseStateCreator.GITHUB_INSTALLATION_ID, jiraHost };
 
+		githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 		githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 		githubNock
 			.get(`/repos/integrations/test-repo-name/actions/runs?per_page=20&page=21`)

src/sync/code-scanning-alerts.test.ts

@@ -51,6 +51,7 @@ describe("sync/code-scanning-alerts", () => {
 				.get("/repos/integrations/test-repo-name/code-scanning/alerts?per_page=20&page=1&sort=created&direction=desc")
 				.reply(200, codeScanningAlerts);
 			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 			jiraNock
 				.post("/rest/security/1.0/bulk", expectedResponseCloudServer(subscription))
 				.reply(200);
@@ -73,6 +74,7 @@ describe("sync/code-scanning-alerts", () => {
 				.get("/repos/integrations/test-repo-name/code-scanning/alerts?per_page=20&page=1&sort=created&direction=desc")
 				.reply(200, []);
 			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 			// No Jira Nock
 
 			await expect(processInstallation(mockBackfillQueueSendMessage)(data, sentry, getLogger("test"))).toResolve();
@@ -86,6 +88,7 @@ describe("sync/code-scanning-alerts", () => {
 				.get("/repos/integrations/test-repo-name/code-scanning/alerts?per_page=20&page=1&sort=created&direction=desc")
 				.reply(403, { message: "Code scanning is not enabled for this repository" });
 			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 			// No Jira Nock
 
 			await expect(processInstallation(mockBackfillQueueSendMessage)(data, sentry, getLogger("test"))).toResolve();
@@ -99,6 +102,7 @@ describe("sync/code-scanning-alerts", () => {
 				.get("/repos/integrations/test-repo-name/code-scanning/alerts?per_page=20&page=1&sort=created&direction=desc")
 				.reply(403, { message: "Advanced Security must be enabled for this repository to use code scanning" });
 			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 			// No Jira Nock
 
 			await expect(processInstallation(mockBackfillQueueSendMessage)(data, sentry, getLogger("test"))).toResolve();
@@ -112,6 +116,7 @@ describe("sync/code-scanning-alerts", () => {
 				.get("/repos/integrations/test-repo-name/code-scanning/alerts?per_page=20&page=1&sort=created&direction=desc")
 				.reply(404, { message: "Ano analysis found" });
 			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 			// No Jira Nock
 
 			await expect(processInstallation(mockBackfillQueueSendMessage)(data, sentry, getLogger("test"))).toResolve();
@@ -125,6 +130,7 @@ describe("sync/code-scanning-alerts", () => {
 				.get("/repos/integrations/test-repo-name/code-scanning/alerts?per_page=20&page=1&sort=created&direction=desc")
 				.reply(404);
 			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 			// No Jira Nock
 
 			await expect(processInstallation(mockBackfillQueueSendMessage)(data, sentry, getLogger("test"))).toResolve();
@@ -138,6 +144,7 @@ describe("sync/code-scanning-alerts", () => {
 				.get("/repos/integrations/test-repo-name/code-scanning/alerts?per_page=20&page=1&sort=created&direction=desc")
 				.reply(451);
 			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 			// No Jira Nock
 
 			await expect(processInstallation(mockBackfillQueueSendMessage)(data, sentry, getLogger("test"))).toResolve();
@@ -191,6 +198,7 @@ describe("sync/code-scanning-alerts", () => {
 				}
 			};
 			gheUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			gheUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 			gheNock
 				.get("/api/v3/repos/integrations/test-repo-name/code-scanning/alerts?per_page=20&page=1&sort=created&direction=desc")
 				.reply(200, codeScanningAlerts);
@@ -216,6 +224,7 @@ describe("sync/code-scanning-alerts", () => {
 				}
 			};
 			gheUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			gheUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 			gheNock
 				.get("/api/v3/repos/integrations/test-repo-name/code-scanning/alerts?per_page=20&page=1&sort=created&direction=desc")
 				.reply(200, []);

src/sync/commits.test.ts

@@ -89,6 +89,7 @@ describe("sync/commits", () => {
 				.create();
 
 			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 		});
 
 		const verifyMessageSent = async (data: BackfillMessagePayload, delaySec ?: number) => {
@@ -260,6 +261,7 @@ describe("sync/commits", () => {
 			gitHubServerApp = builderResult.gitHubServerApp!;
 
 			gheUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			gheUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 		});
 
 		const makeExpectedJiraResponse = async (commits) => ({

src/sync/dependabot-alerts.test.ts

@@ -53,6 +53,7 @@ describe("sync/dependabot-alerts", () => {
 			const data = { installationId: DatabaseStateCreator.GITHUB_INSTALLATION_ID, jiraHost };
 			nockDependabotAlertsRequest(dependabotAlerts);
 			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 			jiraNock
 				.post(
 					"/rest/security/1.0/bulk",
@@ -79,6 +80,7 @@ describe("sync/dependabot-alerts", () => {
 				"data": []
 			});
 			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 			// No Jira Nock
 
 			await expect(processInstallation(mockBackfillQueueSendMessage)(data, sentry, getLogger("test"))).toResolve();
@@ -92,6 +94,7 @@ describe("sync/dependabot-alerts", () => {
 				.get("/repos/integrations/test-repo-name/dependabot/alerts?per_page=20&page=1&sort=created&direction=desc")
 				.reply(403, { message: "Dependabot alerts are disabled for this repository" });
 			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 			// No Jira Nock
 
 			await expect(processInstallation(mockBackfillQueueSendMessage)(data, sentry, getLogger("test"))).toResolve();
@@ -105,6 +108,7 @@ describe("sync/dependabot-alerts", () => {
 				.get("/repos/integrations/test-repo-name/dependabot/alerts?per_page=20&page=1&sort=created&direction=desc")
 				.reply(403, { message: "Dependabot alerts are not available for archived repositories" });
 			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 			// No Jira Nock
 
 			await expect(processInstallation(mockBackfillQueueSendMessage)(data, sentry, getLogger("test"))).toResolve();
@@ -118,6 +122,7 @@ describe("sync/dependabot-alerts", () => {
 				.get("/repos/integrations/test-repo-name/dependabot/alerts?per_page=20&page=1&sort=created&direction=desc")
 				.reply(404);
 			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 			// No Jira Nock
 
 			await expect(processInstallation(mockBackfillQueueSendMessage)(data, sentry, getLogger("test"))).toResolve();
@@ -131,6 +136,7 @@ describe("sync/dependabot-alerts", () => {
 				.get("/repos/integrations/test-repo-name/dependabot/alerts?per_page=20&page=1&sort=created&direction=desc")
 				.reply(451);
 			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			githubUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 			// No Jira Nock
 
 			await expect(processInstallation(mockBackfillQueueSendMessage)(data, sentry, getLogger("test"))).toResolve();
@@ -188,6 +194,7 @@ describe("sync/dependabot-alerts", () => {
 				}
 			};
 			gheUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			gheUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 			nockDependabotAlertsRequest(dependabotAlerts);
 			jiraNock
 				.post(
@@ -215,6 +222,7 @@ describe("sync/dependabot-alerts", () => {
 				}
 			};
 			gheUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
+			gheUserTokenNock(DatabaseStateCreator.GITHUB_INSTALLATION_ID);
 			nockDependabotAlertsRequest({
 				"data": []
 			});
@@ -357,4 +365,4 @@ const expectedResponseGHEServer = (subscription: Subscription) => ({
 		"workspaceId": subscription.id
 	},
 	"operationType": "BACKFILL"
-});
+});

src/sync/deployment.test.ts

@@ -320,6 +320,7 @@ describe("sync/deployments", () => {
 			githubUserTokenNock(installationId);
 			githubUserTokenNock(installationId);
 			githubUserTokenNock(installationId);
+			githubUserTokenNock(installationId);
 
 			createGitHubNock(deploymentNodesFixture);
 			const lastEdges = deploymentNodesFixture.data.repository.deployments.edges;
@@ -458,6 +459,7 @@ describe("sync/deployments", () => {
 					githubUserTokenNock(installationId);
 					githubUserTokenNock(installationId);
 					githubUserTokenNock(installationId);
+					githubUserTokenNock(installationId);
 					githubNock.get(`/repos/test-repo-owner/test-repo-name/commits/${commitId}`)
 						.reply(200, {
 							commit: {
@@ -620,6 +622,7 @@ describe("sync/deployments", () => {
 			const lastEdges = deploymentNodesFixture.data.repository.deployments.edges;
 			createGitHubNock({ data: { repository: { deployments: { edges: [] } } } }, lastEdges[lastEdges.length -1].cursor);
 
+			githubUserTokenNock(installationId);
 			githubUserTokenNock(installationId);
 			githubNock.get(`/repos/test-repo-owner/test-repo-name/commits/51e16759cdac67b0d2a94e0674c9603b75a840f6`)
 				.reply(200, {
@@ -650,6 +653,7 @@ describe("sync/deployments", () => {
 		it("should not call Jira if no data is returned", async () => {
 			const data = { installationId, jiraHost };
 
+			githubUserTokenNock(installationId);
 			createGitHubNock({
 				data: {
 					repository: {
@@ -732,6 +736,7 @@ describe("sync/deployments", () => {
 			gheUserTokenNock(installationId);
 			gheUserTokenNock(installationId);
 			gheUserTokenNock(installationId);
+			gheUserTokenNock(installationId);
 
 			createGitHubServerNock(deploymentNodesFixture);
 			const lastEdges = deploymentNodesFixture.data.repository.deployments.edges;