[INNO] ARC-2714 - Adding modals for backfill page #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krazziekay
changed the title
…adding-modals-for-backfill-page
…adding-modals-for-backfill-page
|
@krazziekay It'd be great if you added a ticket for this work on the board and linked it to the PR :) |
| const GitHubCloudConnections = ({ | ||
| ghCloudSubscriptions, | ||
| }: GitHubCloudConnectionsProps) => { | ||
| const [isModalOpened, setIsModalOpened] = useState(false); | ||
| const [subscriptionForModal, setSubscriptionForModal] = useState<SuccessfulConnection | undefined>(undefined); | ||
| const [selectedModal, setSelectedModal] = useState<BackfillPageModalTypes>("BACKFILL"); |
There was a problem hiding this comment.
It'd be good to create an enum for this instead of using strings
There was a problem hiding this comment.
I don't think its supported in webpack.
Simply following up on how we're using it in other places in spa. Can see the comment here in this file.
krazziekay
changed the title
|
Can we add some tests for these files? |
Have added 2 test cases for the 2 modals. But will add more once we have endpoints running, which will happen in the next PR. |
kamaksheeAtl
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Why
Screenshot
Whats Next?