Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

None fix yarn lock file remove optional on build #2615

Closed
wants to merge 8 commits into from
Closed

None fix yarn lock file remove optional on build #2615

wants to merge 8 commits into from

Conversation

gxueatlassian
Copy link
Contributor

What's in this PR?

  1. Update lock file to be publici yarnpkg instead atlassian
  2. Remove optional during build/test (because even yarn install --ignore-optional, yarn still "consult" the server for meta data, which is blocked by 401 recently from Atlassian)

Why

  1. To fix the public build

Added feature flags
N/A

Affected issues
N/A

How has this been tested?
github action

Whats Next?
N/A

@gxueatlassian gxueatlassian marked this pull request as ready for review December 13, 2023 23:01
@gxueatlassian gxueatlassian requested a review from a team as a code owner December 13, 2023 23:01
@gxueatlassian gxueatlassian marked this pull request as draft December 14, 2023 01:16
@gxueatlassian gxueatlassian deleted the NONE-fix-yarn-lock-file-remove-optional-on-build branch December 14, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gxueatlassian