ft-google auth-#187419119 #10

MugemaneBertin2001 · 2024-06-19T16:46:47Z

what does this PR do?

This pr enables the user to authenticate with existing Google account in eagles-ec-fe

vercel · 2024-06-19T16:46:50Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eagles-ec-fe	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 27, 2024 0:39am

codeclimate · 2024-06-24T10:34:22Z

coverage/lcov-report/prettify.js

+            for (var ao = 0; ao < X; ++ao) {
+              aa = T[ao];
+              ai = ag.match(aa[1]);
+              if (ai) {


Avoid deeply nested control flow statements.

codeclimate · 2024-06-24T10:34:22Z

coverage/lcov-report/prettify.js

+          if (af === "u" || af === "x") {
+            return parseInt(ah.substring(2), 16);
+          } else {
+            return ah.charCodeAt(1);


Avoid too many return statements within this function.

codeclimate · 2024-06-24T10:34:22Z

coverage/lcov-report/prettify.js

+    var Z = [];
+    var W = 0;
+    var S;
+    if (V.currentStyle) {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-06-24T10:34:22Z

coverage/lcov-report/prettify.js

+    var ab = /\r\n?|\n/;
+    var ac = V.ownerDocument;
+    var S;
+    if (V.currentStyle) {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-06-24T10:34:23Z

coverage/lcov-report/block-navigation.js

@@ -0,0 +1,85 @@
+/* eslint-disable */
+var jumpToCode = (function init() {


Function init has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.

codeclimate

The PR diff size of 5100 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 5116 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 5116 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 5125 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 5790 lines exceeds the maximum allowed for the inline comments feature.

codeclimate · 2024-06-27T10:02:39Z

coverage/lcov-report/sorter.js

@@ -0,0 +1,196 @@
+/* eslint-disable */
+var addSorting = (function() {


Function addSorting has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.

codeclimate · 2024-06-27T10:02:39Z

src/pages/RegisterUser.tsx

-            <button
-              type="submit"
-              className="border flex items-center justify-center py-3 px-10 text-[13px] md:text-lg rounded-sm"
+            <a


Identical blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-06-27T10:02:39Z

src/pages/Login.tsx

-            <button
-              type="button"
-              className="border flex items-center font-normal justify-center py-2.5 text-[16px] rounded-sm"
+            <a


Identical blocks of code found in 2 locations. Consider refactoring.

codecov-commenter · 2024-06-27T10:04:43Z

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.37%. Comparing base (1b6ad2e) to head (ddd157b).

Files	Patch %	Lines
src/pages/Login.tsx	83.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev      #10      +/-   ##
==========================================
+ Coverage   76.05%   76.37%   +0.32%     
==========================================
  Files          37       38       +1     
  Lines         618      635      +17     
  Branches       66       68       +2     
==========================================
+ Hits          470      485      +15     
- Misses        146      149       +3     
+ Partials        2        1       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

soleil00

LGTM

teerenzo · 2024-06-27T12:14:34Z

.github/workflows/deploy.yml

@@ -26,7 +26,7 @@ jobs:
          node-version: "20"

      - name: Install dependencies
-        run: npm install
+        run: npm install --legacy-peer-deps


don't change this

teerenzo · 2024-06-27T12:14:47Z

.husky/pre-commit

-npm run test
+# npm run test


uncomment this

teerenzo · 2024-06-27T12:32:45Z

.env

@@ -0,0 +1 @@
+VITE_BASE_URL = http://localhost:499/api/v1


don't push .env create .env.example instead

codeclimate · 2024-06-27T12:39:26Z

Code Climate has analyzed commit ddd157b and detected 0 issues on this pull request.

View more on Code Climate.

MugemaneBertin2001 changed the title ~~Auth: user can login with google auth-~~ Auth: user can login with google auth-#187419119 Jun 19, 2024

MugemaneBertin2001 changed the title ~~Auth: user can login with google auth-#187419119~~ ft-google auth-#187419119 Jun 19, 2024

MugemaneBertin2001 requested review from Heisjabo, teerenzo, yvanddniyo, Jovz19200, niyobertin, soleil00 and dniwemugisha June 19, 2024 16:54

MugemaneBertin2001 force-pushed the ft-google-auth-#187419119 branch from a325f8e to 6737a9d Compare June 24, 2024 10:33

codeclimate bot reviewed Jun 24, 2024

View reviewed changes

MugemaneBertin2001 force-pushed the ft-google-auth-#187419119 branch from 6737a9d to 1279415 Compare June 24, 2024 16:10

vercel bot had a problem deploying to Preview June 24, 2024 16:10 Failure

codeclimate bot reviewed Jun 24, 2024

View reviewed changes

MugemaneBertin2001 added the ready for review label Jun 24, 2024

MugemaneBertin2001 force-pushed the ft-google-auth-#187419119 branch from 1279415 to a8331d4 Compare June 25, 2024 09:20

vercel bot had a problem deploying to Preview June 25, 2024 09:20 Failure

codeclimate bot reviewed Jun 25, 2024

View reviewed changes

MugemaneBertin2001 force-pushed the ft-google-auth-#187419119 branch from a8331d4 to 6bb631a Compare June 25, 2024 12:09

vercel bot had a problem deploying to Preview June 25, 2024 12:09 Failure

codeclimate bot reviewed Jun 25, 2024

View reviewed changes

MugemaneBertin2001 force-pushed the ft-google-auth-#187419119 branch from 6bb631a to 23e2bd6 Compare June 25, 2024 12:19

vercel bot had a problem deploying to Preview June 25, 2024 12:19 Failure

codeclimate bot reviewed Jun 25, 2024

View reviewed changes

MugemaneBertin2001 force-pushed the ft-google-auth-#187419119 branch from 23e2bd6 to fc10cd9 Compare June 25, 2024 13:26

vercel bot had a problem deploying to Preview June 25, 2024 13:26 Failure

codeclimate bot reviewed Jun 25, 2024

View reviewed changes

MugemaneBertin2001 force-pushed the ft-google-auth-#187419119 branch from fc10cd9 to 407bd3e Compare June 27, 2024 10:02

codeclimate bot reviewed Jun 27, 2024

View reviewed changes

vercel bot deployed to Preview June 27, 2024 10:02 View deployment

MugemaneBertin2001 force-pushed the ft-google-auth-#187419119 branch from 407bd3e to b1c1866 Compare June 27, 2024 10:16

vercel bot deployed to Preview June 27, 2024 10:17 View deployment

niyobertin approved these changes Jun 27, 2024

View reviewed changes

Heisjabo approved these changes Jun 27, 2024

View reviewed changes

soleil00 approved these changes Jun 27, 2024

View reviewed changes

teerenzo requested changes Jun 27, 2024

View reviewed changes

MugemaneBertin2001 force-pushed the ft-google-auth-#187419119 branch from b1c1866 to 18b5946 Compare June 27, 2024 12:20

vercel bot deployed to Preview June 27, 2024 12:20 View deployment

MugemaneBertin2001 requested a review from teerenzo June 27, 2024 12:21

teerenzo requested changes Jun 27, 2024

View reviewed changes

.env Outdated

@@ -0,0 +1 @@

VITE_BASE_URL = http://localhost:499/api/v1

Copy link

Member

teerenzo Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't push .env create .env.example instead

Auth: user can login with google auth

ddd157b

MugemaneBertin2001 force-pushed the ft-google-auth-#187419119 branch from 18b5946 to ddd157b Compare June 27, 2024 12:39

vercel bot deployed to Preview June 27, 2024 12:39 View deployment

teerenzo approved these changes Jun 27, 2024

View reviewed changes

teerenzo merged commit 7136e3b into dev Jun 27, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ft-google auth-#187419119 #10

ft-google auth-#187419119 #10

MugemaneBertin2001 commented Jun 19, 2024 •

edited

Loading

vercel bot commented Jun 19, 2024 •

edited

Loading

codeclimate bot Jun 24, 2024

codeclimate bot Jun 24, 2024

codeclimate bot Jun 24, 2024

codeclimate bot Jun 24, 2024

codeclimate bot Jun 24, 2024

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot Jun 27, 2024

codeclimate bot Jun 27, 2024

codeclimate bot Jun 27, 2024

codecov-commenter commented Jun 27, 2024 •

edited

Loading

soleil00 left a comment

teerenzo Jun 27, 2024

teerenzo Jun 27, 2024

teerenzo Jun 27, 2024

codeclimate bot commented Jun 27, 2024

		@@ -0,0 +1,85 @@
		/* eslint-disable */
		var jumpToCode = (function init() {

		@@ -0,0 +1,196 @@
		/* eslint-disable */
		var addSorting = (function() {

ft-google auth-#187419119 #10

ft-google auth-#187419119 #10

Conversation

MugemaneBertin2001 commented Jun 19, 2024 • edited Loading

what does this PR do?

vercel bot commented Jun 19, 2024 • edited Loading

codeclimate bot Jun 24, 2024

Choose a reason for hiding this comment

codeclimate bot Jun 24, 2024

Choose a reason for hiding this comment

codeclimate bot Jun 24, 2024

Choose a reason for hiding this comment

codeclimate bot Jun 24, 2024

Choose a reason for hiding this comment

codeclimate bot Jun 24, 2024

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot Jun 27, 2024

Choose a reason for hiding this comment

codeclimate bot Jun 27, 2024

Choose a reason for hiding this comment

codeclimate bot Jun 27, 2024

Choose a reason for hiding this comment

codecov-commenter commented Jun 27, 2024 • edited Loading

Codecov Report

soleil00 left a comment

Choose a reason for hiding this comment

teerenzo Jun 27, 2024

Choose a reason for hiding this comment

teerenzo Jun 27, 2024

Choose a reason for hiding this comment

teerenzo Jun 27, 2024

Choose a reason for hiding this comment

codeclimate bot commented Jun 27, 2024

MugemaneBertin2001 commented Jun 19, 2024 •

edited

Loading

vercel bot commented Jun 19, 2024 •

edited

Loading

codecov-commenter commented Jun 27, 2024 •

edited

Loading