Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#187419144 A buyer should be able to leave feedback/reviews for products #21

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

niyobertin
Copy link
Collaborator

@niyobertin niyobertin commented Jul 10, 2024

What does this PR do?

A buyer should be able to leave feedback/reviews for products

Description of Task to be completed?

-should be able to read a reaview
-should be able to add review
-should be able to edit review
-should be able to remove/delete a review

How should this be manually tested?

Cone a repo cd into it.

  • run: npm i --> to insitall packages
  • run :npm run dev ---> to start the server
    Go to product page.
    open one product
    Start testing by adding, deleting,removing,or editing a reviews. make sure that you have logged in as a buyer and you have parchesed the products.

What are the relevant pivotal tracker/Trello stories?

#187419144

Screenshots.

Screenshot 2024-07-10 at 16 00 28

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eagles-ec-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 5:38pm

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.97%. Comparing base (b2fcb6c) to head (5ba065a).

Files Patch % Lines
src/components/cards/ProductCard.tsx 62.50% 5 Missing and 1 partial ⚠️
src/redux/reducers/reviewSlice.ts 96.34% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #21      +/-   ##
==========================================
+ Coverage   69.53%   70.97%   +1.44%     
==========================================
  Files          68       69       +1     
  Lines        1362     1461      +99     
  Branches      178      191      +13     
==========================================
+ Hits          947     1037      +90     
- Misses        396      404       +8     
- Partials       19       20       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teerenzo
Copy link
Member

check this @niyobertin
image

@niyobertin niyobertin requested review from MugemaneBertin2001 and removed request for Mugema123 July 12, 2024 16:03
@niyobertin niyobertin force-pushed the ft-buyer-feedback/reviews-#187419144 branch from f3364b4 to e0e07fe Compare July 12, 2024 16:04
-should be able to read a reaview
-should be able to add review
-should be able to edit review
-should be able to remove/delete a review

[#187419144]
@niyobertin niyobertin force-pushed the ft-buyer-feedback/reviews-#187419144 branch from e0e07fe to 5ba065a Compare July 12, 2024 17:37
Copy link

codeclimate bot commented Jul 12, 2024

Code Climate has analyzed commit 5ba065a and detected 0 issues on this pull request.

View more on Code Climate.

@teerenzo teerenzo merged commit 701fbe7 into dev Jul 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants